Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Add service name as a command line option #2080

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[tracegen] Add service name as a command line option #2080

merged 1 commit into from
Feb 20, 2020

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls kearls@redhat.com

Which problem is this PR solving?

  • This PR adds a command line option to tracegen for service name. This will help support some more complex test scenarios.

Short description of the changes

  • "-service" has been added as a command line flag

Signed-off-by: Kevin Earls <kearls@redhat.com>
@kevinearls kevinearls requested a review from a team as a code owner February 20, 2020 15:24
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@043b1ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2080   +/-   ##
=========================================
  Coverage          ?   96.39%           
=========================================
  Files             ?      214           
  Lines             ?    10529           
  Branches          ?        0           
=========================================
  Hits              ?    10149           
  Misses            ?      324           
  Partials          ?       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043b1ae...0abb70e. Read the comment docs.

@jpkrohling jpkrohling merged commit 3d05dcd into jaegertracing:master Feb 20, 2020
@kevinearls kevinearls deleted the service-option-for-tracegen branch February 20, 2020 16:21
@yurishkuro yurishkuro changed the title Add service as a command line option [tracegen] Add service name as a command line option Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants