-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved graceful shutdown - Collector #2076
Improved graceful shutdown - Collector #2076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
+ Coverage 96.31% 96.31% +<.01%
==========================================
Files 214 214
Lines 10532 10540 +8
==========================================
+ Hits 10144 10152 +8
Misses 329 329
Partials 59 59
Continue to review full report at Codecov.
|
did you mean to do |
This is on top of #2031. Once that one is merged, this will get rebased and should show only the collector changes. |
zipkinSpansHandler, jaegerBatchesHandler, grpcHandler := handlerBuilder.BuildHandlers() | ||
|
||
c.spanProcessor = handlerBuilder.BuildSpanProcessor() | ||
c.spanHandlers = handlerBuilder.BuildHandlers(c.spanProcessor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a factory? zipkinSpansHandler, jaegerBatchesHandler, grpcHandler
can implement Factory.CreateHandler()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, probably as part of another PR.
Codecov Report
@@ Coverage Diff @@
## master #2076 +/- ##
=========================================
Coverage ? 96.33%
=========================================
Files ? 214
Lines ? 10537
Branches ? 0
=========================================
Hits ? 10151
Misses ? 328
Partials ? 58
Continue to review full report at Codecov.
|
@annanay25, @yurishkuro is this ready to be merged once 1.17 is out? |
I haven't reviewed this one. Let's merge the agent change and rebase this PR. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Which problem is this PR solving?
Resolves #295