Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing max log level for gRPC storage plugins #1962

Merged
merged 4 commits into from
Dec 5, 2019
+15 −3
Merged

Allow changing max log level for gRPC storage plugins #1962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
200ea18
Add support for CLI flag grpc-storage-plugin.log-level
yyyogev Dec 4, 2019
67b5bc3
Add test for grpc log level
yyyogev Dec 4, 2019
1c9df8f
Fix log level flag description
yyyogev Dec 4, 2019
ccff013
fix formatting
yyyogev Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for grpc log level 
Signed-off-by: yyyogev <yogev.metzuyanim@logz.io>
  • Loading branch information
@yyyogev
yyyogev committed Dec 4, 2019
commit 67b5bc3f3575bf40d398d1969d7766cc1ab46dfe
2 changes: 2 additions & 0 deletions plugin/storage/grpc/factory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,10 @@ func TestWithConfiguration(t *testing.T) {
command.ParseFlags([]string{
"--grpc-storage-plugin.binary=noop-grpc-plugin",
"--grpc-storage-plugin.configuration-file=config.json",
"--grpc-storage-plugin.log-level=debug",
})
f.InitFromViper(v)
assert.Equal(t, f.options.Configuration.PluginBinary, "noop-grpc-plugin")
assert.Equal(t, f.options.Configuration.PluginConfigurationFile, "config.json")
assert.Equal(t, f.options.Configuration.PluginLogLevel, "debug")
}
2 changes: 2 additions & 0 deletions plugin/storage/grpc/options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ func TestOptionsWithFlags(t *testing.T) {
command.ParseFlags([]string{
"--grpc-storage-plugin.binary=noop-grpc-plugin",
"--grpc-storage-plugin.configuration-file=config.json",
"--grpc-storage-plugin.log-level=debug",
})
opts.InitFromViper(v)

assert.Equal(t, opts.Configuration.PluginBinary, "noop-grpc-plugin")
assert.Equal(t, opts.Configuration.PluginConfigurationFile, "config.json")
assert.Equal(t, opts.Configuration.PluginLogLevel, "debug")
}