-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cassandra] Allow turning off tags/logs indexing #1915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
+ Coverage 98.45% 98.45% +<.01%
==========================================
Files 198 198
Lines 9706 9740 +34
==========================================
+ Hits 9556 9590 +34
Misses 114 114
Partials 36 36
Continue to review full report at Codecov.
|
joe-elliott
changed the title
Add drop all filters for each tag type
[cassandra] Drop filters for tag indexing by type
Nov 11, 2019
Manually tested in our environment. Dropping draft status. |
joe-elliott
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
November 11, 2019 14:33
yurishkuro
reviewed
Nov 11, 2019
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all_test.go
Outdated
Show resolved
Hide resolved
plugin/storage/cassandra/spanstore/dbmodel/tag_filter_drop_all.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
force-pushed
the
log-filter
branch
from
November 11, 2019 19:39
dd98a55
to
2946e14
Compare
yurishkuro
approved these changes
Nov 11, 2019
yurishkuro
changed the title
[cassandra] Drop filters for tag indexing by type
[cassandra] Allow turning off tags/logs indexing
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
index