Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go fmt and lint on test files #1709

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

yurishkuro
Copy link
Member

For some reason we were excluding them.

Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro changed the title Run go fmt on test files Run go fmt and lint on test files Aug 3, 2019
@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #1709 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1709   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files         193      193           
  Lines        9274     9274           
=======================================
  Hits         9136     9136           
  Misses        110      110           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b6023...774f972. Read the comment docs.

Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro force-pushed the run-go-fmt-on-tests branch from 07a4868 to 774f972 Compare August 3, 2019 13:28
@jpkrohling jpkrohling merged commit f04f5e5 into jaegertracing:master Aug 5, 2019
@yurishkuro yurishkuro deleted the run-go-fmt-on-tests branch August 5, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants