[badger] Make default dirs work in Windows #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Windows also, fixes issue jaegertracing#1652 Signed-off-by: Michael Burman <yak@iki.fi>
burmanm
force-pushed
the
badger_default_dir
branch
from
86dbe1f
to
c137280
Compare
|
I don't think travis test failures are because of changes in this PR |
yurishkuro
approved these changes
Jul 4, 2019
yurishkuro
changed the title
|
restarting |
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
=========================================
+ Coverage 98.7% 98.7% +<.01%
=========================================
Files 193 193
Lines 9219 9224 +5
=========================================
+ Hits 9100 9105 +5
+ Misses 92 91 -1
- Partials 27 28 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #1652 (Windows default directories do not work), but also ensures that the directories are created successfully since badger only creates the last directory - not the missing parent directories. This is why default directory does not work unless
datais created first.Short description of the changes
Use os.pathSeparator instead of hardcoded
/and create directories if possible.