Remove deprecated index prefix separator : from Elastic #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
objectiser
approved these changes
Jun 21, 2019
| @@ -304,6 +297,7 @@ func (s *SpanReader) multiRead(ctx context.Context, traceIDs []model.TraceID, st | |||
| // i.e starts in one and ends in another. | |||
| indices := s.timeRangeIndices(s.spanIndexPrefix, startTime.Add(-time.Hour), endTime.Add(time.Hour)) | |||
| nextTime := model.TimeAsEpochMicroseconds(startTime.Add(-time.Hour)) | |||
| fmt.Println(indices) | |||
There was a problem hiding this comment.
Did you mean to leave this?
There was a problem hiding this comment.
no, it was just to debug locally
| {params:SpanReaderParams{Client:client, Logger: logger, MetricsFactory: metricsFactory, | ||
| IndexPrefix:"", UseReadWriteAliases: true}, | ||
| indices: []string{spanIndex+"read"}}, | ||
| index: spanIndex+"read"}, | ||
| {params:SpanReaderParams{Client:client, Logger: logger, MetricsFactory: metricsFactory, | ||
| IndexPrefix:"foo:", Archive: false}, |
There was a problem hiding this comment.
nit: Change the IndexPrefix values so just "foo" rather than including ':'.
There was a problem hiding this comment.
It's there to stress that : would be added if it is specified
Codecov Report
@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 98.74% 98.74% -0.01%
==========================================
Files 191 191
Lines 9169 9165 -4
==========================================
- Hits 9054 9050 -4
Misses 89 89
Partials 26 26
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jaeger 1.9.0 the index prefix separator was changed from ":" (not allowed in ES7) to "-". However query still reads from deprecated indices to keep backward compatibility. After half year old indices should be expired so safe to remove.
https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md#190-2019-01-21