-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query service: fix sending status to health check channel #1598
Conversation
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 191 191
Lines 9162 9162
=======================================
Hits 9053 9053
Misses 85 85
Partials 24 24 Continue to review full report at Codecov.
|
Good catch (this is what we get for not having tests in that pkg). However, it does not address the issue, I still got the same error messages
|
Thanks for the review! After bit of reading, i found that the way we do So, to remove errors in logs we could check for such expected shutdown error and not throw/log error in those cases. Thoughts? |
Yes, and that's precisely what changed between 1.11 and 1.12 - we introduced a new cmux multiplexor, which is what seems to be logging the errors. |
Signed-off-by: Abhilash Gnan abhilashgnan@gmail.com
Which problem is this PR solving?
Resolves #1542
Short description of the changes
This PR fixes how we send serviceUnavailable to healthcheck channel on SIGTERM so the query service is shutdown gracefully