Add CA certs to all-in-one image #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandresh-pancholi
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
pavolloffay
reviewed
May 20, 2019
cmd/all-in-one/Dockerfile
Outdated
| @@ -21,6 +21,7 @@ EXPOSE 14250 | |||
| # Web HTTP | |||
| EXPOSE 16686 | |||
|
|
|||
| COPY --from=certs /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt | |||
There was a problem hiding this comment.
This is not everything, we need also these lines
https://github.com/jaegertracing/jaeger/blob/master/cmd/collector/Dockerfile#L1-L2
There was a problem hiding this comment.
aha, my bad. raised the PR in a hurry. Lesson learned.
thanks for the comment.
There was a problem hiding this comment.
Also please move this COPY statement right after the from scratch, then it's ready to be merged.
chandresh-pancholi
force-pushed
the
jaeger-1545
branch
from
99bd410 to
1e73b09
Compare
Codecov Report
@@ Coverage Diff @@
## master #1554 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 190 190
Lines 9061 9061
=======================================
Hits 8952 8952
Misses 85 85
Partials 24 24Continue to review full report at Codecov.
|
…sticsearch backend. (jaegertracing#1545) Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
chandresh-pancholi
force-pushed
the
jaeger-1545
branch
from
1e73b09 to
cb277a7
Compare
pavolloffay
approved these changes
May 20, 2019
pavolloffay
changed the title
|
thanks @chandresh-pancholi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sticsearch backend. (#1545)
Signed-off-by: chandresh-pancholi chandreshpancholi007@gmail.com
Which problem is this PR solving?
Short description of the changes