Expose tls.InsecureSkipVerify to es.tls.* CLI flags #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvassilev
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
==========================================
+ Coverage 99.83% 99.83% +<.01%
==========================================
Files 179 179
Lines 8554 8559 +5
==========================================
+ Hits 8540 8545 +5
Misses 7 7
Partials 7 7
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Apr 15, 2019
plugin/storage/es/options.go
Outdated
| flagSet.Bool( | ||
| nsConfig.namespace+suffixSkipHostVerify, | ||
| nsConfig.TLS.SkipHostVerify, | ||
| "Skip server's certificate chain and host name verification") |
There was a problem hiding this comment.
Please add "(insecure)" prefix to the help string
stefanvassilev
force-pushed
the
ssl_verify
branch
from
9b7bd2b to
8c49b3b
Compare
Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
stefanvassilev
force-pushed
the
ssl_verify
branch
from
8c49b3b to
820a881
Compare
yurishkuro
approved these changes
Apr 18, 2019
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
SkipHostVerifyfield toTLSConfigstruct, exposed by.tls.skip-host-verifyCLI flag