Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default zap sampling config to nil #1460

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

psinghal20
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Changes the default sampling config for the zap logger to nil

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #1460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         173      173           
  Lines        8162     8162           
=======================================
  Hits         8148     8148           
  Misses          7        7           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2260...d1e629b. Read the comment docs.

@yurishkuro yurishkuro merged commit 8b2a2c1 into jaegertracing:master Apr 4, 2019
@yurishkuro
Copy link
Member

thanks!

Signed-off-by: psinghal20 <psinghal20@gmail.com>
@psinghal20 psinghal20 deleted the no-default-sampling branch September 23, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants