Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow thrift reporter even if grpc hosts are not provided #1400

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Allow thrift reporter even if grpc hosts are not provided #1400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8760e2
Allow thrift reporter even if grpc hosts are not provided
pavolloffay Mar 4, 2019
eab8541
Fix all-in-one
pavolloffay Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix all-in-one 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
  • Loading branch information
@pavolloffay
pavolloffay committed Mar 4, 2019
commit eab8541f953d93cc40736e34a7003963dd32a5d6
1 change: 1 addition & 0 deletions cmd/all-in-one/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ func startAgent(
) {
metricsFactory := baseFactory.Namespace(metrics.NSOptions{Name: "agent", Tags: nil})

grpcRepOpts.CollectorHostPort = append(grpcRepOpts.CollectorHostPort, fmt.Sprintf("127.0.0.1:%d", cOpts.CollectorGRPCPort))
cp, err := agentApp.CreateCollectorProxy(repOpts, tchanRep, grpcRepOpts, logger, metricsFactory)
if err != nil {
logger.Fatal("Could not create collector proxy", zap.Error(err))
Expand Down