-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support secure gRPC channel between agent and collector #1391
Support secure gRPC channel between agent and collector #1391
Conversation
Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch>
Signed-off-by: Thomas Gosteli <thomas.gosteli@postfinance.ch>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
======================================
Coverage 100% 100%
======================================
Files 164 164
Lines 7460 7488 +28
======================================
+ Hits 7460 7488 +28
Continue to review full report at Codecov.
|
Signed-off-by: Yuri Shkuro <ys@uber.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:stamp:
Hi, I configured a tls on p 14250 between Agent and Collector and Using a wireshark container sniffing I can see the spans which means they aren't encrypted (Did the same TLS checkup on Collector to elastic and data was encrypted). Attaching sniffing snapshot. Thanks, |
Extends PR #1311 (which was in ghouscht:master, hard to add to directly)