Make grpc reporter default and add retry #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
ghost
assigned
pavolloffay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
======================================
Coverage 100% 100%
======================================
Files 164 164
Lines 7447 7453 +6
======================================
+ Hits 7447 7453 +6
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Feb 26, 2019
pavolloffay
changed the title
pavolloffay
force-pushed
the
make-grpc-default
branch
from
43008c4
to
bfbf3bc
Compare
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
vprithvi
reviewed
Feb 26, 2019
| conn, _ := grpc.Dial(target, | ||
| grpc.WithInsecure(), | ||
| grpc.WithBalancerName(roundrobin.Name), | ||
| grpc.WithUnaryInterceptor(grpc_retry.UnaryClientInterceptor(grpc_retry.WithMax(o.MaxRetry)))) |
There was a problem hiding this comment.
How does this retry work? Is it possible to configure it with exponential backoff, or some backoff for e.g.?
There was a problem hiding this comment.
By default it is using BackoffLinearWithJitter. Which can be changed.
https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/retry/options.go#L26
|
Travis passed, I will try to restart it and hope :) |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
yurishkuro
approved these changes
Feb 26, 2019
|
I have restarted the build 4 times, it passed. I will merge this to see how it behaves in other repositories |
Closed
annanay25
pushed a commit
to annanay25/jaeger
that referenced
this pull request
Mar 1, 2019
* Make grpc reporter default and add retry Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Polish Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix port Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Polish Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Use higher retry Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Increase retry to 100 Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1218 #1229
Signed-off-by: Pavol Loffay ploffay@redhat.com