Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Downsampling writer that drop a percentage of spans #1353

Merged
merged 20 commits into from
Mar 12, 2019
Merged

Add a Downsampling writer that drop a percentage of spans #1353

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ec1be0e
adding a wrapping writer that automatic drop spans before writing wit…
Feb 13, 2019
3392861
updating comment
Feb 14, 2019
927dd8e
hash traceID for downsampling and code refactoring
Feb 15, 2019
a2782ea
adding DownSamplingOptions
Feb 15, 2019
d310bcd
address yuri's comments
Feb 15, 2019
1d665f4
committing benchmark file & adding metrics
Feb 19, 2019
53f74d3
address comment from Won
Feb 20, 2019
8447a8e
get rid of defer; benchmark sync.Pool for byte array; make sure 100% …
Feb 21, 2019
a5f31af
making sure sync.Pool benchmark with 0 allocations
Feb 21, 2019
bc0a72d
refactor to read ratio and hashsalt from CLI
Feb 23, 2019
6338ae8
address yuri comments
Feb 25, 2019
ef6bf28
refinement
Feb 25, 2019
2681941
fix merge conflict
Feb 26, 2019
1802fcf
copy hashSalt slice inside bytePool initialization
Feb 27, 2019
287ffe5
further comments from yuri
Mar 7, 2019
5eff22d
omit error check for MarshalTo
Mar 7, 2019
49fab4c
update naming and some logic
Mar 9, 2019
815e56c
remove pointer
Mar 9, 2019
54051a8
updating tests
Mar 11, 2019
abdc0fb
adding default salt
Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updating comment 
Signed-off-by: Jude Wang <judew@uber.com>
  • Loading branch information
Jude Wang committed Mar 11, 2019
commit 3392861d508849de427f783caca57772dd6477c0
1 change: 1 addition & 0 deletions storage/spanstore/automate_dropping_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ type AutomateDroppingWriter struct {

// NewAutomateDroppingWriter creates a AutomateDroppingWriter
func NewAutomateDroppingWriter(spanWriter Writer, percentage float64) *AutomateDroppingWriter {
// span with TraceID.Low below this threshold won't be written
threshold := uint64(percentage * float64(math.MaxUint64))
return &AutomateDroppingWriter{
spanWriter: spanWriter,
Expand Down