Make it possible for esCleaner.py to use a username/password #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necting to elasticsearch Signed-off-by: Greg Franklin <gregoryfranklin@rentalcars.com>
gregoryfranklin
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7277 7277
======================================
Hits 7277 7277Continue to review full report at Codecov.
|
black-adder
approved these changes
Feb 6, 2019
|
thanks! |
pavolloffay
reviewed
Feb 7, 2019
| @@ -15,7 +15,13 @@ def main(): | |||
| print('ARCHIVE ... specifies whether to remove archive indices. Use true or false') | |||
| sys.exit(1) | |||
|
|
|||
| client = elasticsearch.Elasticsearch(sys.argv[2:]) | |||
| username = os.getenv("ES_USERNAME") | |||
There was a problem hiding this comment.
These should be added into the help print
iori-yja
pushed a commit
to iori-yja/jaeger
that referenced
this pull request
Feb 15, 2019
…necting to elasticsearch (jaegertracing#1318) Signed-off-by: Iori Yoneji <fivo.11235813@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1317
Add optional ES_USERNAME and ES_PASSWORD environment variables in order that esCleaner.py can authenticate against elasticsearch clusters.