Fix duplicated span when querying Elasticsearch [#1297] #1298
Conversation
Volcannozzz
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
| @@ -293,7 +293,7 @@ func (s *SpanReader) multiRead(ctx context.Context, traceIDs []string, startTime | |||
| if len(traceIDs) == 0 { | |||
| break | |||
| } | |||
|
|
|||
| searchRequests := make([]*elastic.SearchRequest, len(traceIDs)) | |||
There was a problem hiding this comment.
this isn't the most efficient fix, ideally we alloc just once and play around with the indices rather than alloc each iteration. We can leave a TODO for now.
There was a problem hiding this comment.
this isn't the most efficient fix, ideally we alloc just once and play around with the indices rather than alloc each iteration. We can leave a TODO for now.
Good suggestion.We(@crazycomputer) have fixed it and will test it in our project tommorrow.If success,i will make a standard PR again.
|
please see https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work to pass the DCO check |
|
Please fix the PR title to reflect the change being made (what it fixes goes into description). PR title typically goes into the final commit comment, and should follow the guidelines in CONTRIBUTING. |
pavolloffay
changed the title
|
done in #1677 thanks @Volcannozzz |
Resolves #1297