Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dep migration #1240

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Dep migration #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
609bb9c
Migrate to dep
isaachier Dec 7, 2018
a2e06b7
Warn on install-glide and redirect to use dep
Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We gratefully welcome improvements to documentation as well as to code.

## Getting Started

This library uses [glide](https://github.com/Masterminds/glide) to manage dependencies.
This library uses [dep](https://golang.github.io/dep) to manage dependencies.

To get started, make sure you clone the Git repository into the correct location `github.com/jaegertracing/jaeger` relative to `$GOPATH`:

Expand All @@ -28,7 +28,7 @@ Then install dependencies and run the tests:

```
git submodule update --init --recursive
glide install
dep ensure
make test
```

Expand Down Expand Up @@ -84,7 +84,7 @@ github.com/jaegertracing/jaeger
jaeger/
sampling/
zipkincore/
glide.yaml - Glide is the project's dependency manager
Gopkg.toml - Dep is the project's dependency manager
mkdocs.yml - MkDocs builds the documentation in docs/
```

Expand All @@ -100,13 +100,13 @@ This projects follows the following pattern for grouping imports in Go files:
* imports from standard library
* imports from other projects
* imports from `jaeger` project

For example:

```go
import (
"fmt"

"github.com/uber/jaeger-lib/metrics"
"go.uber.org/zap"

Expand Down
Loading