Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix childspan context while tracing cassandra queries #1131

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

annanay25
Copy link
Member

Which problem is this PR solving?

  • PR fixes childSpan context in the cassandra query tracer.

Short description of the changes

  • Child-spans should be created with context, which was missing earlier.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1131   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         142     142           
  Lines        6743    6743           
======================================
  Hits         6743    6743
Impacted Files Coverage Δ
plugin/storage/cassandra/spanstore/reader.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9d212...e710a90. Read the comment docs.

@black-adder
Copy link
Contributor

changes look good, you'll have to sign all commits though: https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md#sign-your-work

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro
Copy link
Member

please git commit --amend -s to add the sign-off

Signed-off-by: Annanay <annanay.a@media.net>
@annanay25
Copy link
Member Author

Thanks!

@yurishkuro yurishkuro merged commit 4a07b78 into jaegertracing:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants