Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock detector hack for Kafka driver instability #1087

Merged
merged 11 commits into from
Oct 9, 2018
Merged

Deadlock detector hack for Kafka driver instability #1087

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
493329c
Add seppuku factory
vprithvi Sep 25, 2018
ba9e170
Merge branch 'master' into seppuku
vprithvi Sep 27, 2018
7dba654
Merge branch 'master' into seppuku
black-adder Oct 1, 2018
0f870db
Rename
vprithvi Oct 4, 2018
01d65a6
Address feedback
vprithvi Oct 4, 2018
c818b70
Address feedback
vprithvi Oct 5, 2018
bed08c4
Address feedback
vprithvi Oct 8, 2018
f243e40
Address feedback
vprithvi Oct 8, 2018
4085d54
Merge branch 'master' into seppuku
vprithvi Oct 8, 2018
52f1a16
Make test not flakey
vprithvi Oct 8, 2018
4573d51
Refactor panic tests
vprithvi Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make test not flakey 
Signed-off-by: Prithvi Raj <p.r@uber.com>
  • Loading branch information
@vprithvi
vprithvi committed Oct 8, 2018
commit 52f1a168d74333e7f2cdb04ca2d8b21080ac6024
4 changes: 2 additions & 2 deletions cmd/ingester/app/consumer/deadlock_detector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ func TestPanicFunc(t *testing.T) {
func TestPanicForPartition(t *testing.T) {
mf := metrics.NewLocalFactory(0)
l, _ := zap.NewDevelopment()
f := newDeadlockDetector(mf, l, 1*time.Millisecond)
wg := sync.WaitGroup{}
wg.Add(1)
f := newDeadlockDetector(mf, l, time.Millisecond)
f.panicFunc = func(partition int32) {
wg.Done()
}
Expand All @@ -96,9 +96,9 @@ func TestPanicForPartition(t *testing.T) {
func TestGlobalPanic(t *testing.T) {
mf := metrics.NewLocalFactory(0)
l, _ := zap.NewDevelopment()
f := newDeadlockDetector(mf, l, 1*time.Millisecond)
wg := sync.WaitGroup{}
wg.Add(1)
f := newDeadlockDetector(mf, l, time.Millisecond)
f.panicFunc = func(partition int32) {
wg.Done()
}
Expand Down