Fix race condition #103
Merged
Fix race condition #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Apr 12, 2017
cmd/agent/app/agent_test.go
Outdated
| @@ -88,6 +88,6 @@ func TestAgentStartStop(t *testing.T) { | |||
| body, err := ioutil.ReadAll(resp.Body) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, "tcollector error: no peers available\n", string(body)) | |||
| agent.Stop() | |||
| assert.NoError(t, <-ch) | |||
There was a problem hiding this comment.
isn't this going to deadlock? Nothing writing to this channel until we call Stop
This reverts commit 58b8114.
black-adder
changed the title
|
I gave up on the DeadLock fix, there's some pretty arcane logic there. We'll probably rip it out for something else. |
yurishkuro
approved these changes
Apr 13, 2017
|
Changes Unknown when pulling 26b768b on fix_baaaaad_tests into ** on master**. |
ideepika
pushed a commit
to ideepika/jaeger
that referenced
this pull request
Oct 22, 2017
chlunde
added a commit
to chlunde/jaeger
that referenced
this pull request
Oct 30, 2020
Make a tiny state machine to detect the transition init -> stopped (not via serving) Fixes jaegertracing#2601 Related jaegertracing#103 Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
yurishkuro
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a race condition in TestAgentStartStop and a deadlock in TestQueue.