Log cql query on error (#1250)

Signed-off-by: Prithvi Raj <p.r@uber.com>
jaegertracing · Jan 1, 2019 · fe7352d · fe7352d
1 parent eed786f
commit fe7352d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugin/storage/cassandra/spanstore/reader.go b/plugin/storage/cassandra/spanstore/reader.go
@@ -410,7 +410,8 @@ func (s *SpanReader) executeQuery(span opentracing.Span, query cassandra.Query,
 	tableMetrics.Emit(err, time.Since(start))
 	if err != nil {
 		logErrorToSpan(span, err)
-		s.logger.Error("Failed to exec query", zap.Error(err))
+		span.LogFields(otlog.String("query", query.String()))
+		s.logger.Error("Failed to exec query", zap.Error(err), zap.String("query", query.String()))
 		return nil, err
 	}
 	return retMe, nil

diff --git a/plugin/storage/cassandra/spanstore/reader_test.go b/plugin/storage/cassandra/spanstore/reader_test.go
@@ -305,6 +305,7 @@ func TestSpanReaderFindTraces(t *testing.T) {
 					query.On("Consistency", cassandra.One).Return(query)
 					query.On("PageSize", 0).Return(query)
 					query.On("Iter").Return(iter)
+					query.On("String").Return("queryString")
 
 					return query
 				}