Skip to content

Commit

Permalink
Clarify that "kafka" is not a real storage backend (#2066)
Browse files Browse the repository at this point in the history
* Clarify that "kafka" is not a real storage backend

Signed-off-by: Yuri Shkuro <ys@uber.com>

* use quotes

Signed-off-by: Yuri Shkuro <ys@uber.com>

* update

Signed-off-by: Yuri Shkuro <ys@uber.com>
  • Loading branch information
yurishkuro authored Feb 10, 2020
1 parent a8d76b0 commit e2411e5
Showing 1 changed file with 20 additions and 3 deletions.
23 changes: 20 additions & 3 deletions cmd/env/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,32 @@ command line option environment variable
The following configuration options are only available via environment variables:
%s
`
storageTypeDescription = `The type of backend [%s] used for trace storage.
Multiple backends can be specified as comma-separated list, e.g. "cassandra,elasticsearch"
(currently only for writing spans). Note that "kafka" is only valid in jaeger-collector;
it is not a replacement for a proper storage backend, and only used as a buffer for spans
when Jaeger is deployed in the collector+ingester configuration.
`
)

// Command creates `env` command
func Command() *cobra.Command {
fs := new(pflag.FlagSet)
fs.String(storage.SpanStorageTypeEnvVar, "cassandra", fmt.Sprintf("The type of backend %s used for trace storage. Multiple backends can be specified (currently only for writing spans) as comma-separated list, e.g. \"cassandra,kafka\".", storage.AllStorageTypes))
fs.String(storage.DependencyStorageTypeEnvVar, "${SPAN_STORAGE}", "The type of backend used for service dependencies storage.")
long := fmt.Sprintf(longTemplate, strings.Replace(fs.FlagUsagesWrapped(0), " --", "", -1))
fs.String(
storage.SpanStorageTypeEnvVar,
"cassandra",
fmt.Sprintf(
strings.ReplaceAll(storageTypeDescription, "\n", " "),
strings.Join(storage.AllStorageTypes, ", "),
),
)
fs.String(
storage.DependencyStorageTypeEnvVar,
"${SPAN_STORAGE_TYPE}",
"The type of backend used for service dependencies storage.",
)
long := fmt.Sprintf(longTemplate, strings.Replace(fs.FlagUsagesWrapped(0), " --", "\n", -1))
return &cobra.Command{
Use: "env",
Short: "Help about environment variables.",
Expand Down

0 comments on commit e2411e5

Please sign in to comment.