Skip to content

Commit

Permalink
Fix error equals (#2429)
Browse files Browse the repository at this point in the history
* Fix broken test in go 1.15

Signed-off-by: albertteoh <alber.teoh@logz.io>

* More explicit and specific assertions

Signed-off-by: albertteoh <alber.teoh@logz.io>

Co-authored-by: albertteoh <alber.teoh@logz.io>
  • Loading branch information
albertteoh and albertteoh authored Aug 28, 2020
1 parent 4062992 commit b5b2d79
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions cmd/query/app/query_parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,15 @@
package app

import (
"fmt"
"net/http"
"regexp"
"testing"
"time"

"github.com/kr/pretty"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/jaegertracing/jaeger/model"
"github.com/jaegertracing/jaeger/storage/spanstore"
Expand All @@ -41,8 +44,8 @@ func TestParseTraceQuery(t *testing.T) {
{"x?service=service&start=string", errParseInt, nil},
{"x?service=service&end=string", errParseInt, nil},
{"x?service=service&limit=string", errParseInt, nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&minDuration=20", "cannot not parse minDuration: time: missing unit in duration 20", nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&minDuration=20s&maxDuration=30", "cannot not parse maxDuration: time: missing unit in duration 30", nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&minDuration=20", `cannot not parse minDuration: time: missing unit in duration "?20"?$`, nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&minDuration=20s&maxDuration=30", `cannot not parse maxDuration: time: missing unit in duration "?30"?$`, nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&tag=k:v&tag=x:y&tag=k&log=k:v&log=k", `malformed 'tag' parameter, expecting key:value, received: k`, nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&minDuration=25s&maxDuration=1s", `'maxDuration' should be greater than 'minDuration'`, nil},
{"x?service=service&start=0&end=0&operation=operation&limit=200&tag=k:v&tag=x:y", noErr,
Expand Down Expand Up @@ -161,7 +164,9 @@ func TestParseTraceQuery(t *testing.T) {
}
}
} else {
assert.EqualError(t, err, test.errMsg)
matched, matcherr := regexp.MatchString(test.errMsg, err.Error())
require.NoError(t, matcherr)
assert.True(t, matched, fmt.Sprintf("Error \"%s\" should match \"%s\"", err.Error(), test.errMsg))
}
})
}
Expand Down

0 comments on commit b5b2d79

Please sign in to comment.