add TODOs

Signed-off-by: Yuri Shkuro <github@ysh.us>
jaegertracing · Sep 1, 2020 · ad4419e · ad4419e
1 parent b64ddea
commit ad4419e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/cmd/collector/app/span_processor.go b/cmd/collector/app/span_processor.go
@@ -141,6 +141,7 @@ func (sp *spanProcessor) saveSpan(span *model.Span) {
 	}
 
 	startTime := time.Now()
+	// TODO context should be propagated from upstream components
 	if err := sp.spanWriter.WriteSpan(context.TODO(), span); err != nil {
 		sp.logger.Error("Failed to save span", zap.Error(err))
 		sp.metrics.SavedErrBySvc.ReportServiceNameForSpan(span)

diff --git a/cmd/ingester/app/processor/span_processor.go b/cmd/ingester/app/processor/span_processor.go
@@ -63,5 +63,6 @@ func (s KafkaSpanProcessor) Process(message Message) error {
 	if err != nil {
 		return fmt.Errorf("cannot unmarshall byte array into span: %w", err)
 	}
+	// TODO context should be propagated from upstream components
 	return s.writer.WriteSpan(context.TODO(), span)
 }