Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualized scrolling for trace detail view #68

Merged
merged 44 commits into from
Sep 8, 2017
Merged

Virtualized scrolling for trace detail view #68

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
fe35bbd
Update prettier and wrap at 110 instead of 80
tiffon Aug 3, 2017
acbfdee
WIP commit for refactoring trace detail view
tiffon Aug 11, 2017
4fa5c8a
WIP commit for refactoring trace detail view
tiffon Aug 14, 2017
93a6fb7
WIP refactor trace detail, split out css, start fixing tests
tiffon Aug 17, 2017
b8945ab
WIP refactor trace detail, tests working again
tiffon Aug 20, 2017
401b083
WIP refactor trace, yarn upgrade
tiffon Aug 20, 2017
c34bbd3
WIP refactor trace, test maintenance
tiffon Aug 20, 2017
c041353
remove unused import
tiffon Aug 20, 2017
9f54454
add license to css files
tiffon Aug 20, 2017
c657cf1
Revert sub-page scrolling for trace detail
tiffon Aug 20, 2017
2226744
Support URL prefix via homepage in package.json
tiffon Aug 20, 2017
f555e8b
Prevent collision of logs in log entries table
tiffon Aug 20, 2017
bef7f5b
Add comments to new utils
tiffon Aug 21, 2017
8101efd
WIP Use react-virtualized in trace detail view
tiffon Aug 21, 2017
fa6f016
Fix #59 - "Span Name" to "Service & Operation"
tiffon Aug 21, 2017
3797f5b
Fix unreleased regression - ellipsis on span name
tiffon Aug 21, 2017
0fd43f5
Address PR comment on search results scatter plot
tiffon Aug 21, 2017
542c1ba
Misc cleanup from PR comment
tiffon Aug 21, 2017
42736e0
PR comment - Remove ms and use nano seconds
tiffon Aug 21, 2017
d16097b
PR comment - Adjust export, relates to recompose
tiffon Aug 21, 2017
83b28d5
Reorganize span detail components
tiffon Aug 22, 2017
bdd6d7e
PR comment - Comment getTraceSpanIdsAsTree()
tiffon Aug 22, 2017
7204684
PR comment - Add "SpanID:" label
tiffon Aug 22, 2017
9bdf8b6
Merge branch 'refactor-trace-detail-selectors' into span-detail-reorg
tiffon Aug 22, 2017
da7bbb2
Merge branch 'refactor-trace-detail-selectors' into milestone1/issue-…
tiffon Aug 22, 2017
762b1b1
Merge branch 'span-detail-reorg' into milestone1/issue-60-react-virtu…
tiffon Aug 22, 2017
0ed6fde
WIP react-virtualized layout progress
tiffon Aug 22, 2017
284c816
WIP react-virtualized layout progress
tiffon Aug 23, 2017
0113985
Merge branch 'master' into span-detail-reorg
tiffon Aug 24, 2017
5c7f896
PR comment - Flow typing for props
tiffon Aug 24, 2017
650c60b
Merge branch 'span-detail-reorg' into milestone1/issue-60-react-virtu…
tiffon Aug 24, 2017
d1fd592
WIP Switching react-virtualized to custom solution
tiffon Aug 28, 2017
831aa9c
fix file-header licenses
tiffon Aug 28, 2017
3eeec40
WIP Switching react-virtualized to custom solution
tiffon Aug 28, 2017
c749135
Merge branch 'master' into milestone1/issue-60-react-virtualized
tiffon Aug 28, 2017
11fa23e
Add flow to ListView, comment ListView, Positions
tiffon Aug 29, 2017
c88e723
Positions tests, fix edge-case bug in Positions
tiffon Aug 29, 2017
f8dd6b8
Fix comment issue from prettier
tiffon Aug 29, 2017
cd45e62
Unit tests for ListView, remove unused propType/*
tiffon Aug 30, 2017
f45d360
Minor changes to a comment and a test case description
tiffon Aug 30, 2017
ff2ae49
Unit tests for TraceTimelineViewer/duck
tiffon Aug 31, 2017
3c8057e
remove react-virtualized from package.json
tiffon Sep 1, 2017
6059fed
PR feedback - JSDoc, move trace transform
tiffon Sep 5, 2017
ff779db
Use top-level redux store for traceTimeline state
tiffon Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused import
  • Loading branch information
@tiffon
tiffon committed Aug 20, 2017
commit c0413539ac43ccacdd3f13b20d5c21a54c844d24
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"prettier": "^1.5.3",
"react-scripts": "^1.0.11",
"react-test-renderer": "^15.6.1",
"sets-equal": "^1.0.0",
"sinon": "^3.2.1",
"uber-licence": "^3.1.1"
},
Expand Down
1 change: 0 additions & 1 deletion src/selectors/trace.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
// THE SOFTWARE.

import _values from 'lodash/values';
import setsEqual from 'sets-equal';

import traceGenerator from '../../src/demo/trace-generators';
import * as traceSelectors from '../../src/selectors/trace';
Expand Down
10 changes: 0 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4655,10 +4655,6 @@ make-dir@^1.0.0:
dependencies:
pify "^2.3.0"

make-set@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/make-set/-/make-set-1.0.0.tgz#5e507e3c57b7ce04d00426e31cc404db703d73d2"

makeerror@1.0.x:
version "1.0.11"
resolved "https://registry.yarnpkg.com/makeerror/-/makeerror-1.0.11.tgz#e01a5c9109f2af79660e4e8b9587790184f5a96c"
Expand Down Expand Up @@ -6601,12 +6597,6 @@ setprototypeof@1.0.3:
version "1.0.3"
resolved "https://registry.yarnpkg.com/setprototypeof/-/setprototypeof-1.0.3.tgz#66567e37043eeb4f04d91bd658c0cbefb55b8e04"

sets-equal@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/sets-equal/-/sets-equal-1.0.0.tgz#19a08ebfab3bdde2a75efb23cc66ee2c69d15e44"
dependencies:
make-set "^1.0.0"

settle-promise@1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/settle-promise/-/settle-promise-1.0.0.tgz#697adb58b821f387ce2757c06efc9de5f0ee33d8"
Expand Down