Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SPM) Add span kind selector #2012

Merged
merged 13 commits into from
Dec 4, 2023
Merged

(SPM) Add span kind selector #2012

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f2552cb
Add span kind selector
albertteoh Dec 2, 2023
7b86eca
Rename single word to two words
albertteoh Dec 2, 2023
49c0401
Update snapshots and test
albertteoh Dec 2, 2023
78937f0
Merge branch 'main' into add-span-kind-selector
albertteoh Dec 2, 2023
c6bade9
Fix import formatting
albertteoh Dec 2, 2023
3cb5605
yarn prettier
albertteoh Dec 2, 2023
07e3c26
Remove redundant 'Choose' from title
Dec 2, 2023
46989de
Default to 'server'
Dec 2, 2023
ccd6cc7
Remove optionality in API query param fields
Dec 2, 2023
62a71da
Add behavioural tests for spanKind selector
Dec 3, 2023
c1ed381
Fix import formatting
Dec 3, 2023
71c43af
Fix import formatting
Dec 3, 2023
ff1ab7b
yarn prettier
Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove optionality in API query param fields 
Signed-off-by: Albert Teoh <albert@packsmith.io>
  • Loading branch information
Albert Teoh committed Dec 2, 2023
commit ccd6cc76fc4f4d34178978ce7b3a4f03aaab0182
10 changes: 5 additions & 5 deletions packages/jaeger-ui/src/types/metrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ export type spanKinds = 'unspecified' | 'internal' | 'server' | 'client' | 'prod
export type MetricsAPIQueryParams = {
quantile: number;
groupByOperation?: boolean;
endTs?: number;
lookback?: number;
step?: number;
ratePer?: number;
spanKind?: spanKinds;
endTs: number;
lookback: number;
step: number;
ratePer: number;
spanKind: spanKinds;
};

export type LableObject = {
Expand Down