Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit mergeChildrenCriticalPath early for an empty critical path #1974

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Exit mergeChildrenCriticalPath early for an empty critical path #1974

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b73419e
mergeChildrenCriticalPath shortcuts for an empty critical path
maxgaponov Nov 13, 2023
f9831f3
Merge branch 'main' into improve-critical-path
yurishkuro Nov 13, 2023
adaad39
Refactor the fix
maxgaponov Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@
spanID: string,
criticalPath: criticalPathSection[]
): criticalPathSection[] {
if (criticalPath.length == 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter complains
166:27 error Expected '===' and instead saw '=='

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't this be just if (!criticalPath) ?

return criticalPath;

Check warning on line 167 in packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx

View check run for this annotation

Codecov / codecov/patch

packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx#L167 

Added line #L167 was not covered by tests
}
// Define an array to store the IDs of the span and its descendants (if the span is collapsed)
const allRequiredSpanIds = [spanID];

Expand Down
Loading