Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: Enhancement to selfTime calculation logic in TraceStatistics view #1901

Merged
merged 12 commits into from
Oct 24, 2023
Merged

[Refactor]: Enhancement to selfTime calculation logic in TraceStatistics view #1901

merged 12 commits into from
Oct 24, 2023

Commits on Oct 21, 2023

  1. Enhancement to selfTime calculation logic 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    b02cde1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Minimized the code complexity 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    3db728f View commit details
    Browse the repository at this point in the history

  2. Edited test fixtures 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    53dd0df View commit details
    Browse the repository at this point in the history

  3. Multiplied with 10 to Drange intervals to avoid improper overlaps 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    79991df View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Added comments to explain the logic of the code 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ac620db View commit details
    Browse the repository at this point in the history

  2. Renamed a trace file name 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    108829c View commit details
    Browse the repository at this point in the history

  3. Modified the code 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    a1e3b4a View commit details
    Browse the repository at this point in the history

  4. Update packages/jaeger-ui/src/components/TracePage/TraceStatistics/ta… 

    …bleValues.tsx

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: GLVSKiriti <116095646+GLVSKiriti@users.noreply.github.com>
    @GLVSKiriti @yurishkuro
    GLVSKiriti and yurishkuro authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    50e0a39 View commit details
    Browse the repository at this point in the history

  5. Updated to suggested changes 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    df59065 View commit details
    Browse the repository at this point in the history

  6. computeSelfTime function is introduced 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c91f7d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Updated code and comments to suggested changes 

    Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
    @GLVSKiriti
    GLVSKiriti committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    44a1da7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into selfTimeEnhancementInTraceStatistics 

    Signed-off-by: GLVSKiriti <116095646+GLVSKiriti@users.noreply.github.com>
    @GLVSKiriti
    GLVSKiriti authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ce1f573 View commit details
    Browse the repository at this point in the history