Restore ability to search in Select fields

[prathamesh-mutkure]

Which problem is this PR solving?

• Example: Resolves [Bug]: Can not use search in service or Operation #1784

Description of the changes

• All the Ant Design's Select fields are now searchable
• Added new util to override default behaviour of searching by value instead of label

How was this change tested?

• The test was done manually
• I'll add tests if this approach seems okay

Screenshot

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[prathamesh-mutkure]

Let me fix the tests

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Files	Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx	98.23% <ø> (ø)
...r-ui/src/components/SearchTracePage/SearchForm.jsx	92.15% <100.00%> (ø)
...components/SearchTracePage/SearchResults/index.tsx	86.15% <ø> (ø)
...i/src/components/TracePage/TraceSpanView/index.tsx	89.39% <ø> (ø)
...eger-ui/src/components/common/SearchableSelect.tsx	100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

[yurishkuro]

• missing sign-off on some commits
• need to regenerate snapshot (yarn test -u in packages/jaeger-ui)

[yurishkuro]

You're missing the test of actually searching when typing. Instead of testing the internal findBy... function, you could've made those same tests from the perspective of the end user, who is typing into the field, not calling a function.

[prathamesh-mutkure]

Yes, that's how we initially planned to do it but isn't the part for showing matching options on the UI handled by Ant Design that is already tested? I can add an explicit UI test if that makes more sense

[yurishkuro]

Recently we broke the ability to search and no unit tests failed. If something changes in ant design regarding HOW filtering is supposed to be hooked up, no tests will fail again. So (a) we need to test for that, and (b) why restrict the input permission tests that you have to test inner function if we could test them end to end to the user facing behavior?

[prathamesh-mutkure]

Sure, that makes more sense

[yurishkuro]

I am going to merge this so that it can make it into the next release, we can alter the tests in another PR.