-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all uncontroversial icons from various icon sets to io5 #1771
Replaced all uncontroversial icons from various icon sets to io5 #1771
Conversation
77eeded
to
b7ceef7
Compare
please make sure lint & unit tests succeed |
…fix linting errors Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
6e46cb9
to
f903d39
Compare
I think you need to regenerate the jest snapshots when changing icons, this is why the tests are failing. |
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Done! |
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
…ceTimelineViewer/SpanDetail/KeyValuesTable.tsx file Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageSearchBar.tsx
Show resolved
Hide resolved
packages/jaeger-ui/src/components/common/DetailsCard/DetailTableDropdown.tsx
Outdated
Show resolved
Hide resolved
...eger-ui/src/components/TracePage/TraceTimelineViewer/TimelineHeaderRow/TimelineCollapser.css
Show resolved
Hide resolved
packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.tsx
Outdated
Show resolved
Hide resolved
The rest of the changes looks good 🚀 |
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sure you have re-generated the snapshots.
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
c1f671c
to
286fa87
Compare
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
🎉 |
Signed-off-by: Priyanshu Sharma priyanshushrama709@gmail.com
Which problem is this PR solving?
Description of the changes
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test