Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-virtualized-select with Ant's Select #1737

Merged

Conversation

prathamesh-mutkure
Copy link
Contributor

@prathamesh-mutkure prathamesh-mutkure commented Aug 27, 2023

Which problem is this PR solving?

Description of the changes

  • I've removed the react-virtualized-select, react-virtualized and react-select package
  • The first two were replaced with antd's <Select /> component
  • The last component wasn't used anywhere in jaeger-ui
  • The old components were styled to match the theme of Ant Design used by other components
  • Thus, I removed the CSS files associated with old components as they were no longer needed
  • Updated the test snapshots

How was this change tested?

  • The existing test cases passed
  • And the snapshots were updated
  • The design of new components matched the old ones

Screenshot of changes

Screenshot 2023-08-28 at 4 08 31 AM Screenshot 2023-08-28 at 4 10 34 AM

Checklist

Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Copy link
Contributor Author

@prathamesh-mutkure prathamesh-mutkure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added explanation for removing some props

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28% 🎉

Comparison is base (60093a4) 96.00% compared to head (6a5f536) 96.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
+ Coverage   96.00%   96.28%   +0.28%     
==========================================
  Files         240      239       -1     
  Lines        7514     7492      -22     
  Branches     1974     1964      -10     
==========================================
  Hits         7214     7214              
+ Misses        300      278      -22     
Files Changed Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 98.23% <100.00%> (+0.88%) ⬆️
...r-ui/src/components/SearchTracePage/SearchForm.jsx 92.15% <100.00%> (+0.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -287,15 +283,18 @@ export class SearchFormImpl extends React.PureComponent {
>
<Field
name="service"
component={AdaptedVirtualSelect}
component={AdaptedSelect}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why Service / Operation dropdowns allow only 7 entries simultaneously visible, but Lookback allows 8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting, I'll check this out

@yurishkuro yurishkuro merged commit 0110ed0 into jaegertracing:main Aug 27, 2023
@yurishkuro
Copy link
Member

@prathamesh-mutkure could you please check #1784, if there is a way to re-enable type-to-search capability in Ant Select?

@prathamesh-mutkure prathamesh-mutkure deleted the react-select-upgrade branch October 11, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove react-select and react-virtualized-select for Ant's Select component
2 participants