-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-virtualized-select with Ant's Select #1737
Replace react-virtualized-select with Ant's Select #1737
Conversation
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added explanation for removing some props
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
==========================================
+ Coverage 96.00% 96.28% +0.28%
==========================================
Files 240 239 -1
Lines 7514 7492 -22
Branches 1974 1964 -10
==========================================
Hits 7214 7214
+ Misses 300 278 -22
☔ View full report in Codecov by Sentry. |
@@ -287,15 +283,18 @@ export class SearchFormImpl extends React.PureComponent { | |||
> | |||
<Field | |||
name="service" | |||
component={AdaptedVirtualSelect} | |||
component={AdaptedSelect} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why Service / Operation dropdowns allow only 7 entries simultaneously visible, but Lookback allows 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting, I'll check this out
@prathamesh-mutkure could you please check #1784, if there is a way to re-enable type-to-search capability in Ant Select? |
Which problem is this PR solving?
react-select
andreact-virtualized-select
for Ant's Select component #1735Description of the changes
react-virtualized-select
,react-virtualized
andreact-select
packageantd
's<Select />
componentHow was this change tested?
Screenshot of changes
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test