Skip to content

[Enhancement]: Self time Calculation to be unified across multiple screens #1263

Closed

Description

Requirement

Enhancements to Trace statistics view

  • Similar Self Time as Trace Graph page.
  • Page to load faster for trace containing > 10K spans

Problem

Trace Statistics View is unresponsive for traces > 10K spans if second Group By with high cardinality like tag.db@statement are selected.

Currently, there are 2 views in which self time is computed.

  • Trace Graph
  • Trace Statistics

Both of them follow different logic.
Key difference being Trace Graph ignores the follows-from relationship since the producer span doesn't have any control over when will the consumer span start whereas the Trace Statistics view computes the self time factoring in the time spent between the start of the producer span and start of the consumer span.

Moreover the logic used in trace graph is much simpler and easier to understand whereas the trace statistics view logic is very complex and page is unresponsive when computing self time for traces containing > 10K spans.

Proposal

Use the similar logic in both Trace Graph & Trace Statistics views to compute the self time. If it's alright, I can raise a PR for the same.

Open questions

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions