Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jaegertracing/jaeger-ui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9d0a7b1676d541cdb408b92f4f5dad21e5035445
Choose a base ref
...
head repository: jaegertracing/jaeger-ui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1d8bf21d260360715c4ad6c49b49e01b10dc27eb
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 27, 2023

  1. Replace react-virtualized-select with Ant's Select (#1737)

    ## Which problem is this PR solving?
    - Resolves #1735 
    - Also resolves [PR
    1692](#1692)
    
    ## Description of the changes
    - I've removed the `react-virtualized-select`, `react-virtualized` and
    `react-select` package
    - The first two were replaced with `antd`'s `<Select />` component
    - The last component wasn't used anywhere in jaeger-ui
    - The old components were styled to match the theme of Ant Design used
    by other components
    - Thus, I removed the CSS files associated with old components as they
    were no longer needed
    - Updated the test snapshots
    
    ## How was this change tested?
    - The existing test cases passed
    - And the snapshots were updated
    - The design of new components matched the old ones
    
    Screenshot of changes
    
    <img width="1784" alt="Screenshot 2023-08-28 at 4 08 31 AM"
    src="https://github.com/jaegertracing/jaeger-ui/assets/28570857/f0347dcd-7763-492d-a88a-51da39796dbd">
    
    
    <img width="1784" alt="Screenshot 2023-08-28 at 4 10 34 AM"
    src="https://github.com/jaegertracing/jaeger-ui/assets/28570857/a6b67308-4c9e-4f71-befa-496bfa37ea1b">
    
    
    
    ## Checklist
    - [x] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [x] I have signed all commits
    - [x] I have added unit tests for the new functionality
    - [x] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
    prathamesh-mutkure authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    0110ed0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Bump history from 4.7.2 to 5.3.0

    Bumps [history](https://github.com/remix-run/history) from 4.7.2 to 5.3.0.
    - [Release notes](https://github.com/remix-run/history/releases)
    - [Commits](remix-run/history@v4.7.2...v5.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: history
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1d8bf21 View commit details
    Browse the repository at this point in the history
Loading