Handle FOLLOWS_FROM in scrolling shortcuts

Signed-off-by: Joe Farro <joef@uber.com>
jaegertracing · Nov 2, 2017 · b47aec3 · b47aec3
1 parent d921310
commit b47aec3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Changes merged into master
 
 
+### [#118](https://github.com/jaegertracing/jaeger-ui/pull/118) Handle `FOLLOWS_FROM` reference type
+
+Fix issue processing `FOLLOWS_FROM` references to parent spans. Fixes [#115](https://github.com/jaegertracing/jaeger-ui/issues/115).
+
+
 ### [#110](https://github.com/jaegertracing/jaeger-ui/pull/110) Fix browser back button not working correctly
 
 Fix bug causing browser back button to not work correctly. Fixes [#94](https://github.com/jaegertracing/jaeger-ui/issues/94).

diff --git a/src/components/TracePage/ScrollManager.js b/src/components/TracePage/ScrollManager.js
@@ -59,7 +59,7 @@ function isSpanHidden(span: Span, childrenAreHidden: Set<string>, spansMap: Map<
   let { references } = span;
   let parentID: ?string;
   const checkRef = ref => {
-    if (ref.refType === 'CHILD_OF') {
+    if (ref.refType === 'CHILD_OF' || ref.refType === 'FOLLOWS_FROM') {
       parentID = ref.spanID;
       parentIDs.add(parentID);
       return childrenAreHidden.has(parentID);