Skip to content

Commit

Permalink
Refactor the fix
Browse files Browse the repository at this point in the history
Signed-off-by: Maksim Gaponov <gaponovmaxev@gmail.com>
  • Loading branch information
maxgaponov committed Nov 13, 2023
1 parent f9831f3 commit adaad39
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ function mergeChildrenCriticalPath(
spanID: string,
criticalPath: criticalPathSection[]
): criticalPathSection[] {
if (criticalPath.length == 0) {
return criticalPath;
if (!criticalPath) {
return [];

Check warning on line 167 in packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx

View check run for this annotation

Codecov / codecov/patch

packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.tsx#L167

Added line #L167 was not covered by tests
}
// Define an array to store the IDs of the span and its descendants (if the span is collapsed)
const allRequiredSpanIds = [spanID];
Expand Down

0 comments on commit adaad39

Please sign in to comment.