Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #954

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Update README.md #954

merged 1 commit into from
Mar 10, 2020

Conversation

slikk66
Copy link
Contributor

@slikk66 slikk66 commented Mar 9, 2020

correct ENV var typo in README

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #954 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files          82       82           
  Lines        6523     6523           
=======================================
  Hits         4200     4200           
  Misses       2179     2179           
  Partials      144      144

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d9816...8790409. Read the comment docs.

@jpkrohling
Copy link
Contributor

Nice catch! Thanks for your PR.

Don't mind the examples2 failing test, this is a known issue. This PR looks good to me, but in order for us to merge it, the DCO check has to pass. You might need to follow the instructions from the DCO "details" page.

correct ENV var typo in README

Signed-off-by: Danno B <dan@billeci.com>
@slikk66
Copy link
Contributor Author

slikk66 commented Mar 9, 2020

ok - I followed the DCO check instructions, seems to be passing that check now 👍

@jpkrohling jpkrohling merged commit 577f732 into jaegertracing:master Mar 10, 2020
@jpkrohling
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants