Reorganized cluster roles, added rules to watch all namespaces #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinearls would you be able to test this? It would be good to do the OLM testing as well with this CSV: https://github.com/operator-framework/community-operators/blob/master/docs/testing-operators.md . I believe @jkandasa has done some OLM testing before as well. |
|
@jpkrohling Sure I'll test this shortly |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
931-Cluster-wide-operator
branch
from
36c9638
to
98d3f40
Compare
|
@objectiser would you like to review/give it a try as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the cluster role to include all the rules from the regular role. Unfortunately, we can't compose roles, as the operator-sdk will either bind a service account for the cluster role, or to a role. It cannot bind a service account to both a role and a cluster role (!!).
Related to the finding above, this PR also fixes a problem that went unnoticed with the CSV, which listed a different service account under
clusterPermissions.Fixes #931.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de