Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed user_setup script #890

Merged

Conversation

jpkrohling
Copy link
Contributor

Resolves #889

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

The operator deploys fine with this change in an OCP 4.2 cluster:

$ kubectl logs deployment/jaeger-operator -f
time="2020-02-05T12:42:27Z" level=info msg=Versions arch=amd64 identity=observability.jaeger-operator jaeger=1.16.0 jaeger-operator=v1.16.0-25-gf53ad217 operator-sdk=v0.12.0 os=linux version=go1.13.4
time="2020-02-05T12:42:31Z" level=info msg="Auto-detected the platform" platform=openshift
time="2020-02-05T12:42:31Z" level=info msg="Automatically adjusted the 'es-provision' flag" es-provision=no
time="2020-02-05T12:42:31Z" level=info msg="Automatically adjusted the 'kafka-provision' flag" kafka-provision=no
time="2020-02-05T12:42:31Z" level=info msg="The service account running this operator does not have the role 'system:auth-delegator', consider granting it for additional capabilities"

And minikube:

$ minikube start --vm-driver kvm2 --cpus 6 --memory 12288
...
$ kubectl logs deployment/jaeger-operator
time="2020-02-05T12:55:24Z" level=info msg=Versions arch=amd64 identity=observability.jaeger-operator jaeger=1.16.0 jaeger-operator=v1.16.0-25-gf53ad217 operator-sdk=v0.12.0 os=linux version=go1.13.4
time="2020-02-05T12:55:25Z" level=info msg="Auto-detected the platform" platform=kubernetes
time="2020-02-05T12:55:25Z" level=info msg="Automatically adjusted the 'es-provision' flag" es-provision=no
time="2020-02-05T12:55:25Z" level=info msg="Automatically adjusted the 'kafka-provision' flag" kafka-provision=no
time="2020-02-05T12:55:25Z" level=info msg="The service account running this operator does not have the role 'system:auth-delegator', consider granting it for additional capabilities"
time="2020-02-05T12:55:26Z" level=info msg="Install prometheus-operator in your cluster to create ServiceMonitor objects" error="no ServiceMonitor registered with the API"


@jpkrohling
Copy link
Contributor Author

Image for this PR: quay.io/jpkroehling/jaeger-operator:890-Removed-user_setup-script

@jkandasa
Copy link
Member

jkandasa commented Feb 6, 2020

@jpkrohling I tested this image on OCP 4.2 cluster via OLM.
I do not see any issues.

Tests performed:

  • Installed jaeger-operator (quay.io/jpkroehling/jaeger-operator:890-Removed-user_setup-script) via OLM
  • Deployed Jaeger services with elastic search and performed a minimal test
  • Deployed all-in-one service and performed a minimal test

logs from jaeger-operator:

time="2020-02-06T15:51:56Z" level=info msg=Versions arch=amd64 identity=openshift-operators.jaeger-operator jaeger=1.16.0 jaeger-operator=v1.16.0-25-gf53ad217 operator-sdk=v0.12.0 os=linux version=go1.13.4
time="2020-02-06T15:52:00Z" level=info msg="Auto-detected the platform" platform=openshift
time="2020-02-06T15:52:00Z" level=info msg="Automatically adjusted the 'es-provision' flag" es-provision=yes
time="2020-02-06T15:52:00Z" level=info msg="Automatically adjusted the 'kafka-provision' flag" kafka-provision=no
time="2020-02-06T15:52:00Z" level=info msg="The service account running this operator does not have the role 'system:auth-delegator', consider granting it for additional capabilities"
time="2020-02-06T15:59:27Z" level=info msg="Storage type not provided. Falling back to 'memory'" instance=jaegerqe namespace=jkandasa
time="2020-02-06T15:59:52Z" level=error msg="failed to store the failed status into the current CustomResource after the reconciliation" error="Operation cannot be fulfilled on jaegers.jaegertracing.io \"jaegerqe\": the object has been modified; please apply your changes to the latest version and try again" execution="2020-02-06 15:59:52.776098605 +0000 UTC" instance=jaegerqe namespace=jkandasa
time="2020-02-06T15:59:52Z" level=error msg="failed to apply the changes" error="routes.route.openshift.io \"jaegerqe\" already exists" execution="2020-02-06 15:59:52.776098605 +0000 UTC" instance=jaegerqe namespace=jkandasa

@jpkrohling
Copy link
Contributor Author

Thanks for the confirmation!

@jpkrohling jpkrohling merged commit 6a2a17b into jaegertracing:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove add-user script
2 participants