-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed user_setup script #890
Merged
jpkrohling
merged 1 commit into
jaegertracing:master
from
jpkrohling:889-Remove-user_setup-script
Feb 6, 2020
Merged
Removed user_setup script #890
jpkrohling
merged 1 commit into
jaegertracing:master
from
jpkrohling:889-Remove-user_setup-script
Feb 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
The operator deploys fine with this change in an OCP 4.2 cluster:
And minikube:
|
Image for this PR: quay.io/jpkroehling/jaeger-operator:890-Removed-user_setup-script |
@jpkrohling I tested this image on OCP 4.2 cluster via OLM. Tests performed:
logs from jaeger-operator:
|
Thanks for the confirmation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #889
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de