Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflows publishing the 'master' container image #718

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Oct 21, 2019

The script that is used for this workflow is the same we had before with Travis. It works locally when setting the username/password vars and I did add the same secrets to this repository. I believe this will work, but we'll only know when this gets merged.

Resolves #715

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

This uses the branch's name instead of latest, in line with how we used to do before moving to GitHub Workflows.

jaeger-operator/.travis.yml

Lines 102 to 107 in 7664ef3

- stage: deploy
name: "Publish latest image"
env:
- OPERATOR_VERSION="${TRAVIS_BRANCH}"
script:
- "./.travis/publish-images.sh"

We could change the new .github/workflows/publish-images.yaml to also publish the master images under the latest tag, but I'd do it in a follow-up PR, I'm not 100% sure this PR here will work on the first attempt.

@jpkrohling
Copy link
Contributor Author

@pavolloffay would be the right reviewer, as he's the author of the linked issue, but not sure he is available to review as he is at EclipseCon this week. @kevinearls, would you like to review this one instead?

@kevinearls
Copy link
Contributor

@jpkrohling I'll check this afternoon, although I don't really have much background in this.

Copy link
Contributor

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit 33f5317 into jaegertracing:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish latest/master images for every master build
2 participants