Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default agent tags #648

Merged

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Sep 6, 2019

Closes #632.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling
Copy link
Contributor Author

@objectiser are the go.mod/go.sum changes in line with the ones you observed when running ./.ci/script.sh locally ?

@objectiser
Copy link
Contributor

@jpkrohling yes looks the same from a quick scan.

@jpkrohling
Copy link
Contributor Author

yes looks the same from a quick scan

Need to save some time to properly learn go mod. I thought the dependency list was static, unless we actively ran an update command.

In any case, I'll keep the dependency changes in this PR, as it will otherwise fail due to the unstaged changes to the go.mod/sum files, even though no dependencies actually changed as part of this PR.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix to make

pkg/inject/sidecar_test.go Outdated Show resolved Hide resolved
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject environment information into JAEGER_TAGS env variable
2 participants