Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy production ready self provisioned ES by default #585

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Deploy production ready self provisioned ES by default #585

merged 4 commits into from
Aug 9, 2019

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Aug 8, 2019 •
edited
Loading

Resolves #560

By default deploy 3 nodes and set resources to 16Gb and 1 CPU.

Signed-off-by: Pavol Loffay ploffay@redhat.com

@pavolloffay
Deploy production ready self provisioned ES by default
e663ead 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

@kevinearls @jkandasa heads up this PR can break your internal tests as it changes the ES deployment If you previously were not specifying the number of nodes and resources.

@pavolloffay pavolloffay added the Elasticsearch The issues related to Elasticsearch storage label Aug 8, 2019
@pavolloffay
Parse resources
f00a438 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Fixes
f38a34d 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
objectiser approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comment.

pkg/storage/elasticsearch.go Outdated
@@ -130,6 +130,11 @@ func (ed *ElasticsearchDeployment) InjectSecretsConfiguration(p *corev1.PodSpec)
// Elasticsearch returns an ES CR for the deployment
func (ed *ElasticsearchDeployment) Elasticsearch() *esv1.Elasticsearch {
uuid := strings.Replace(util.DNSName(ed.Jaeger.Namespace+ed.Jaeger.Name), "-", "", -1)
//res := ed.Jaeger.Spec.Storage.Elasticsearch.Resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over?

@pavolloffay
Remove comment
b3cf4f5 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d47a4d4). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #585   +/-   ##
=========================================
  Coverage          ?   91.24%           
=========================================
  Files             ?       73           
  Lines             ?     3667           
  Branches          ?        0           
=========================================
  Hits              ?     3346           
  Misses            ?      228           
  Partials          ?       93
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø)
pkg/strategy/controller.go 97.76% <100%> (ø)
pkg/storage/elasticsearch.go 81.15% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47a4d4...b3cf4f5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d47a4d4). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #585   +/-   ##
=========================================
  Coverage          ?   91.24%           
=========================================
  Files             ?       73           
  Lines             ?     3667           
  Branches          ?        0           
=========================================
  Hits              ?     3346           
  Misses            ?      228           
  Partials          ?       93
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø)
pkg/strategy/controller.go 97.76% <100%> (ø)
pkg/storage/elasticsearch.go 81.15% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47a4d4...b3cf4f5. Read the comment docs.

@pavolloffay pavolloffay merged commit f074040 into jaegertracing:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@objectiser objectiser objectiser approved these changes

Assignees
No one assigned
Labels
Elasticsearch The issues related to Elasticsearch storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provision production ready ES cluster by default
2 participants
@pavolloffay @objectiser