Renamed the ManagedBy label to OperatedBy #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objectiser
approved these changes
Aug 1, 2019
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
Rename-ManagedBy-OperatedBy
branch
from
bbcb1a0
to
885400b
Compare
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 73 73
Lines 3652 3652
=======================================
Hits 3333 3333
Misses 227 227
Partials 92 92
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 73 73
Lines 3652 3652
=======================================
Hits 3333 3333
Misses 227 227
Partials 92 92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion from #571 and feedback from other sources, I think it's worth having a dedicated label key to indicate which operator is managing the instance, instead of using Kubernetes'
app.kubernetes.io/managed-bySigned-off-by: Juraci Paixão Kröhling juraci@kroehling.de