Prevented the Operator from overriding Secrets/ImagePullSecrets on ServiceAccounts

[jpkrohling]

Fixes #521 by not overriding the Secrets, ImagePullSecrets nor AutomountServiceAccountToken fields from service accounts.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

[jpkrohling]

@objectiser right now, we do not set those fields. We might set them in the future (#404 for instance), but if we ever do that, we can just build a merge function to keep the values added from processes outside of the operator.

[jpkrohling]

@samcrutt9900, this should fix #521. If you want to give this one a try, I published the following image: jpkroehling/jaeger-operator:521-Do-not-override-secrets-imagepullsecrets-on-serviceaccounts

[jpkrohling]

cc @knrc, @jwendell, @gbaufake, with this change, the Jaeger Operator should keep your changes to the ServiceAccount objects.

[codecov]

Codecov Report

Merging #526 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   91.97%   91.96%   -0.01%     
==========================================
  Files          69       69              
  Lines        3500     3497       -3     
==========================================
- Hits         3219     3216       -3     
  Misses        196      196              
  Partials       85       85

Impacted Files	Coverage Δ
pkg/inventory/account.go	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d6e8b...46e4c1a. Read the comment docs.

[objectiser]

LGTM