Allowed usage of custom SA for OAuth Proxy #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 91.95% 91.96% +0.01%
==========================================
Files 65 65
Lines 3295 3300 +5
==========================================
+ Hits 3030 3035 +5
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 91.95% 91.96% +0.01%
==========================================
Files 65 65
Lines 3295 3300 +5
==========================================
+ Hits 3030 3035 +5
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
objectiser
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519 by checking the service account from the JaegerSpec and from JaegerQuerySpec and using it when a value is present.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de