Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkerd.io/inject=disabled annotation #507

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

tarvip
Copy link
Contributor

@tarvip tarvip commented Jul 5, 2019

Add annotation to those components that already have similar annotation for Istio

Closes #500

Add annotation to those components that already have similar annotation for Istio

Signed-off-by: Tarvi Pillessaar <tarvip@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #507 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   91.91%   91.94%   +0.02%     
==========================================
  Files          65       65              
  Lines        3279     3290      +11     
==========================================
+ Hits         3014     3025      +11     
  Misses        185      185              
  Partials       80       80
Impacted Files Coverage Δ
pkg/deployment/query.go 100% <100%> (ø) ⬆️
pkg/cronjob/es_rollover.go 95.57% <100%> (+0.07%) ⬆️
pkg/storage/cassandra_dependencies.go 100% <100%> (ø) ⬆️
pkg/deployment/all-in-one.go 100% <100%> (ø) ⬆️
pkg/deployment/collector.go 100% <100%> (ø) ⬆️
pkg/cronjob/spark_dependencies.go 97.8% <100%> (+0.02%) ⬆️
pkg/storage/elasticsearch_dependencies.go 100% <100%> (ø) ⬆️
pkg/deployment/ingester.go 100% <100%> (ø) ⬆️
pkg/cronjob/es_index_cleaner.go 100% <100%> (ø) ⬆️
pkg/deployment/agent.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2670592...effc102. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #507 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   91.91%   91.94%   +0.02%     
==========================================
  Files          65       65              
  Lines        3279     3290      +11     
==========================================
+ Hits         3014     3025      +11     
  Misses        185      185              
  Partials       80       80
Impacted Files Coverage Δ
pkg/deployment/query.go 100% <100%> (ø) ⬆️
pkg/cronjob/es_rollover.go 95.57% <100%> (+0.07%) ⬆️
pkg/storage/cassandra_dependencies.go 100% <100%> (ø) ⬆️
pkg/deployment/all-in-one.go 100% <100%> (ø) ⬆️
pkg/deployment/collector.go 100% <100%> (ø) ⬆️
pkg/cronjob/spark_dependencies.go 97.8% <100%> (+0.02%) ⬆️
pkg/storage/elasticsearch_dependencies.go 100% <100%> (ø) ⬆️
pkg/deployment/ingester.go 100% <100%> (ø) ⬆️
pkg/cronjob/es_index_cleaner.go 100% <100%> (ø) ⬆️
pkg/deployment/agent.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2670592...effc102. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could count 16 changes here, and there are 16 instances of sidecar.istio.io/inject in the code, so, LGTM.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@objectiser objectiser merged commit 48788f0 into jaegertracing:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add annotation: linkerd.io/inject: disabled
3 participants