-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linkerd.io/inject=disabled annotation #507
Conversation
Add annotation to those components that already have similar annotation for Istio Signed-off-by: Tarvi Pillessaar <tarvip@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 91.91% 91.94% +0.02%
==========================================
Files 65 65
Lines 3279 3290 +11
==========================================
+ Hits 3014 3025 +11
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 91.91% 91.94% +0.02%
==========================================
Files 65 65
Lines 3279 3290 +11
==========================================
+ Hits 3014 3025 +11
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could count 16 changes here, and there are 16 instances of sidecar.istio.io/inject
in the code, so, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add annotation to those components that already have similar annotation for Istio
Closes #500