Remove race condition by disabling esIndexCleaner till after SmokeTes… #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t runs Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 64 64
Lines 3130 3130
=======================================
Hits 2852 2852
Misses 196 196
Partials 82 82Continue to review full report at Codecov.
|
|
@objectiser Please review. Note that no variable names contain swears. :-) |
objectiser
reviewed
May 24, 2019
test/e2e/elasticsearch_test.go
Outdated
| @@ -26,6 +27,9 @@ type ElasticSearchTestSuite struct { | |||
| suite.Suite | |||
| } | |||
|
|
|||
| var trueVar = true | |||
| var falseVar = false | |||
There was a problem hiding this comment.
You only need to use a single variable - initialised to false when doing the initial deployment and then updated to true when doing the update.
Signed-off-by: Kevin Earls <kearls@redhat.com>
objectiser
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t runs
Signed-off-by: Kevin Earls kearls@redhat.com