Update to 1.12 and use new admin ports #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 89.72% 89.79% +0.06%
==========================================
Files 64 64
Lines 3096 3115 +19
==========================================
+ Hits 2778 2797 +19
Misses 216 216
Partials 102 102
Continue to review full report at Codecov.
|
pavolloffay
reviewed
May 22, 2019
| @@ -39,10 +40,14 @@ func (a *AllInOne) Get() *appsv1.Deployment { | |||
| labels := a.labels() | |||
| trueVar := true | |||
|
|
|||
| args := append(a.jaeger.Spec.AllInOne.Options.ToArgs()) | |||
|
|
|||
| adminPort := util.GetPort("--admin-http-port=", args, 14269) | |||
There was a problem hiding this comment.
Could you please explain what does 14269? Is it the dafault?
There was a problem hiding this comment.
yes it is the default - so it is just checking for the default being overridden by an arg.
pavolloffay
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown gary@brownuk.com