Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming e2e tests #400

Merged
merged 1 commit into from
May 8, 2019
Merged

Add streaming e2e tests #400

merged 1 commit into from
May 8, 2019

Conversation

objectiser
Copy link
Contributor

Reworking on #391 using the testify package.

Signed-off-by: Gary Brown gary@brownuk.com

Signed-off-by: Gary Brown <gary@brownuk.com>
@objectiser objectiser requested a review from kevinearls May 7, 2019 16:27
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          64       64           
  Lines        3092     3092           
=======================================
  Hits         2774     2774           
  Misses        216      216           
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59aa90b...b2e844f. Read the comment docs.

Copy link
Contributor

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@objectiser objectiser merged commit 97350c6 into jaegertracing:master May 8, 2019
@objectiser objectiser deleted the streame2e branch May 8, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants