Use "latest" as the image version when none is set #37
Conversation
The version can be empty when developing with "go run main.go" so to avoid having Kubernetes fail to deploy Jaeger because the image is incorrect, we use "latest" as the default Signed-off-by: Georgios Andrianakis <geoand@gmail.com>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 99.16% 99.16% +<.01%
==========================================
Files 16 16
Lines 599 602 +3
==========================================
+ Hits 594 597 +3
Misses 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)
pkg/deployment/all-in-one.go, line 30 at r1 (raw file):
if len(imageVersion) == 0 { // default to latest when no version has been set imageVersion = "latest"
I like the main idea, but we should default to whatever is specified in the jaeger.version file, at the root of the repository. As the main use case is when running the operator with go run, I think we could then try to load this file and use it?
But, I think a better solution to this specific problem is to add -ldflags to the make run target and instruct people to not use go run directly (which is reasonable, I think).
|
I am pretty new to |
|
I agree that we should add the |
|
Yes, please! |
|
Closing in favor of #35 |
The version can be empty when developing with "go run main.go" so to
avoid having Kubernetes fail to deploy Jaeger because the image is
incorrect, we use "latest" as the default
Signed-off-by: Georgios Andrianakis geoand@gmail.com